Repository navigation
fix: security - upgrade undici to 8.12.2 and 7.30.1 - #1746
Merged
Merged
Conversation
The direct dependency floor is now ^8.12.2. The 7.x override is now 7.30.1. miniflare pins undici 7.29.1, so that override stays. Co-authored-by: Jared Wray <me@jaredwray.com>
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
Review the following changes in direct dependencies. Learn more about Socket for GitHub.
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1746 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 29 29
Lines 3620 3620
Branches 811 824 +13
=========================================
Hits 3620 3620 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Please check if the PR fulfills these requirements
What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
Security fix. This change upgrades undici.
Aikido reports three High advisories on undici 8.11.2 and 7.30.0:
The patched releases are undici 8.12.2, 7.30.1, and 6.29.1. This repo does not install the 6.x line.
Versions
Before:
@cacheable/netdepends on undici^8.11.2. The lockfile resolves 8.11.2.After:
@cacheable/netdepends on undici^8.12.2. The lockfile resolves 8.12.2.The lockfile no longer contains undici 8.11.2 or 7.30.0.
Override
miniflare 5.20261006.1-alpha pins undici 7.29.1. That exact pin cannot reach 7.30.1. The existing 7.x override stays, and the pin is now 7.30.1.
docula accepts undici
^8.10.2.@cacheable/netnow accepts^8.12.2. Both ranges include 8.12.2, so the 8.x line does not need an override.Release age
undici 8.12.2 and 7.30.1 were published on 2026-10-15.
minimumReleaseAgeis 10080 minutes, and strict mode is on. The install adds a version exclude for those two releases only.Test audit
This pull request does not add, change, or delete a test. The existing suite still protects the public fetch behavior.
Verification
pnpm installupdated the lockfile.pnpm buildcompleted.node scripts/test-build.mjspassed.pnpm test:cipassed. Biome reported no warnings.@cacheable/netran 212 tests with 100% line coverage.