Skip to content

Comments

cacheable-request - chore: upgrading tsup to 8.5.1#1575

Merged
jaredwray merged 1 commit intomainfrom
cacheable-request---chore-upgrading-tsup-to-8.5.1
Feb 6, 2026
Merged

cacheable-request - chore: upgrading tsup to 8.5.1#1575
jaredwray merged 1 commit intomainfrom
cacheable-request---chore-upgrading-tsup-to-8.5.1

Conversation

@jaredwray
Copy link
Owner

@jaredwray jaredwray commented Feb 6, 2026

Please check if the PR fulfills these requirements

  • Followed the Contributing guidelines and Code of Conduct
  • Tests for the changes have been added (for bug fixes/features) with 100% code coverage.

What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
cacheable-request - chore: upgrading tsup to 8.5.1

@gemini-code-assist
Copy link

Summary of Changes

Hello @jaredwray, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request focuses on routine dependency maintenance for the cacheable-request package. The primary change involves updating the tsup build tool to its latest patch version, along with several other development and production dependency updates. These updates ensure the project remains current with the latest bug fixes and improvements from its underlying libraries.

Highlights

  • Tsup Upgrade: The build tool tsup has been upgraded from version 8.5.0 to 8.5.1.
  • Dependency Updates: Several other dependencies, including @types/http-cache-semantics, @types/node, and rimraf, have been updated to their latest minor or patch versions.
Changelog
  • packages/cacheable-request/package.json
    • Updated @types/http-cache-semantics from ^4.0.4 to ^4.2.0.
    • Updated @types/node from ^25.0.3 to ^25.2.0.
    • Updated rimraf from ^6.1.0 to ^6.1.2.
    • Updated tsup from ^8.5.0 to ^8.5.1.
Activity
  • No human activity (comments, reviews, etc.) has been recorded for this pull request yet.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

@jaredwray jaredwray merged commit ed00175 into main Feb 6, 2026
7 checks passed
@jaredwray jaredwray deleted the cacheable-request---chore-upgrading-tsup-to-8.5.1 branch February 6, 2026 22:23
Copy link

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request aims to update dependencies, but it appears to introduce several invalid package versions in packages/cacheable-request/package.json. The versions specified for @types/http-cache-semantics, @types/node, rimraf, and tsup in the changes do not seem to exist on the public npm registry. This is a critical issue that will likely cause the dependency installation to fail. I have added specific comments with suggestions for valid versions. Please review these and correct the versions for all updated dependencies. Additionally, for better traceability, consider updating the PR title to be more generic, such as 'chore: update dependencies', as more than just tsup is being updated.

},
"dependencies": {
"@types/http-cache-semantics": "^4.0.4",
"@types/http-cache-semantics": "^4.2.0",

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

critical

The version for @types/http-cache-semantics is being updated to ^4.2.0, but this version does not appear to exist on the npm registry. The latest available version is 4.0.4. Using a non-existent version will break dependency installation.

Suggested change
"@types/http-cache-semantics": "^4.2.0",
"@types/http-cache-semantics": "^4.0.4",

"@keyv/sqlite": "^4.0.6",
"@types/express": "^5.0.6",
"@types/node": "^25.0.3",
"@types/node": "^25.2.0",

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

critical

The version for @types/node is specified as ^25.2.0. This seems to be a typo, as Node.js version 25 does not exist, and consequently, neither do its corresponding type definitions. This will cause dependency installation to fail. Please correct this to a valid and existing version, for example, one from the v20.x line which corresponds to the current Node.js LTS.

Suggested change
"@types/node": "^25.2.0",
"@types/node": "^20.14.9",

"express": "^5.2.1",
"pify": "^6.1.0",
"rimraf": "^6.1.0",
"rimraf": "^6.1.2",

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

critical

The version for rimraf is being updated to ^6.1.2. This appears to be incorrect as version 6 of rimraf has not been released. The latest major version is 5. Please correct this to a valid version to avoid breaking the build.

Suggested change
"rimraf": "^6.1.2",
"rimraf": "^5.0.7",

"rimraf": "^6.1.2",
"sqlite3": "^5.1.7",
"tsup": "^8.5.0",
"tsup": "^8.5.1",

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

critical

The version for tsup is being updated to ^8.5.1. This version does not seem to exist on the npm registry. The latest version is 8.1.0. Please use a valid version to ensure dependencies can be installed correctly.

Suggested change
"tsup": "^8.5.1",
"tsup": "^8.1.0",

@codecov
Copy link

codecov bot commented Feb 6, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 100.00%. Comparing base (28607cc) to head (a29d792).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff            @@
##              main     #1575   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           26        26           
  Lines         2444      2444           
  Branches       541       542    +1     
=========================================
  Hits          2444      2444           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant