Expose measured run and step samples in span queries - #218
Merged
Conversation
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
query span --format json|toonexposes recorded run and driver-step samples through a typedtimingblock. Consumers can read the sample series and its statistics without confusing the profiled window with a measured call or step duration.The block names the sample unit, boundary, and clock. Missing samples stay
null; each run-group member keeps its own series. The compactquery spansoverview stays unchanged.Includes the public
SpanTimingexport, documentation, and a minor changeset.Validation: 767 unit tests, 6 measurement tests, TypeScript build, lint, formatting, and unused-code checks pass. Tests cover JSON and TOON, different sample and profile durations, unavailable samples, group provenance, and a real Node record-to-query flow.