Conversation
|
Important Draft PR not reviewedDraft PRs are not automatically reviewed by default.
To automatically review draft PRs, update your CodeRabbit configuration: reviews:
auto_review:
drafts: trueThanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
jamro
force-pushed
the
feat/halloween-mod
branch
from
September 28, 2026 14:57
3efb46e to
0018af7
Compare
Keep each mod's CAD and exports under 3d_models so other files can live beside the models. Co-authored-by: Cursor <cursoragent@cursor.com>
- Added audio clips: abort.wav, attention.wav, error.wav, and welcome.wav, along with a README for the assets directory explaining their usage and format.
Pack stock WAVs, then replace only the files a mod ships. Cue sidecars follow the new lines, and a larger LittleFS image fits the Halloween set. Co-authored-by: Cursor <cursoragent@cursor.com>
jamro
force-pushed
the
feat/halloween-mod
branch
from
September 28, 2026 21:06
3d468b8 to
a7e7c7d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
First community mod, as a worked example of
3d_models/mods/<mod_name>/.Adds an alternate head shaped like a pumpkin. Eye openings are cutouts over the OLED so the panel shows through the shell. Builds that use this head should set
eyes_style=cover: the cover style fills each half of the 128×32 panel with a solid bar, so a hole of any shape stays lit, and existing blink / look sequences only change the black margins.Other stock parts, and firmware stay unchanged. Cover rendering is already in firmware; this PR only adds the optional prints.
The mod may grow a few extra Halloween pieces in the same folder.
Layout:
CERN-OHL-S-2.0, same as the rest of 3d_models/.