Open
Conversation
MichailiK
commented
Oct 11, 2020
Sanduhr32
suggested changes
Oct 11, 2020
Sanduhr32
left a comment
Sanduhr32
left a comment
There was a problem hiding this comment.
Looks like a boiler plate the way it is written.
You probably can do better.
src/main/java/com/jagrosh/vortex/commands/settings/ResetCmd.java
Outdated
Show resolved
Hide resolved
src/main/java/com/jagrosh/vortex/commands/settings/ResetCmd.java
Outdated
Show resolved
Hide resolved
|
LGTM i think |
MichailiK
commented
Nov 18, 2020
src/main/java/com/jagrosh/vortex/database/managers/GuildSettingsDataManager.java
Show resolved
Hide resolved
You could change this method to public if you want. Might want to wait for a reply of @jagrosh whether caches should be kept. |
jagrosh
requested changes
Nov 18, 2020
Owner
jagrosh
left a comment
jagrosh
left a comment
There was a problem hiding this comment.
In terms of functionality this seems fine except for the two changes I suggested. That being said, I'm not sure I'm ready to actually add this to the bot yet. I am going to keep this PR on-hold until I've put more thought into the potential effects of this being available.
src/main/java/com/jagrosh/vortex/commands/settings/ResetCmd.java
Outdated
Show resolved
Hide resolved
Co-authored-by: John Grosh <john.a.grosh@gmail.com>
Co-authored-by: John Grosh <john.a.grosh@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull requests adds a new "reset" command, which allows users to reset Vortex's settings, such as Automod & strikes.
The reset command could be used by all the users that have been asking how to reset Vortex's settings in the support channel.