Repository navigation
Destroy background resources invalidated by Close or Reset - #48
Merged
Merged
Conversation
Destroy resources completed by TryAcquire after Close or Reset. Otherwise Close can wait forever and Reset can reuse a stale resource.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I run Live Tennis API.
If
Closeruns whileTryAcquireis constructing a resource, the constructor can put that resource into the closed pool.Closethen waits forever for its destructor. A concurrentResetcan also leave a stale resource available for acquisition.Check the closed state and reset generation before adding the completed resource to the idle pool. Destroy invalidated resources in the background and release their capacity.
The two new tests synchronize construction with closure and reset. They also check that
Closewaits for destruction and that acquisition afterResetcreates a fresh resource. Both tests fail before the fix.go test -v -race ./...passes on Go 1.19, 1.20 and 1.23.4. Both regressions pass 50 race runs.go build ./...and formatting pass.go vet ./...reports an existing benchmark callingtesting.B.Fatalfrom a goroutine. The same diagnostic occurs on untouched upstream.