Exit jackdbus cleanly on SIGTERM - #1024
Open
iibaranov-IG wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #971.
jackdbuscalledjackctl_setup_signals(0), which blocks the termination signals for later consumption byjackctl_wait_signals(). Unlikejackd, however,jackdbusnever calls the wait function, so SIGTERM remains blocked indefinitely.This installs a small async-signal-safe handler that records the requested termination signal in a
sig_atomic_t. The existing D-Bus dispatch loop checks that flag and performs the normal controller cleanup path. Its existing 200 ms dispatch timeout bounds the exit delay.Validation:
jackdbusremained alive more than 3.2 seconds after SIGTERM and required SIGKILL.Controller received signal 15andController deactivated.python3 ./waf configure --dbus --classicandpython3 ./waf build -j2build in a clean Debian environment.