Open
Conversation
github-actions
bot
added
In progress
alxmcs
requested changes
Mar 5, 2026
| ILogger<VehicleService> logger) : IVehicleService | ||
| { | ||
| /// <inheritdoc /> | ||
| public async Task<Vehicle> GetVehicleAsync(int id) |
Collaborator
There was a problem hiding this comment.
Суффикс Async обычно ставится для методов, у которых есть синхронная имплементация. У тебя такой нет, так что он не нужен
|
|
||
| try | ||
| { | ||
| var expirationMinutes = configuration.GetValue("CacheSettings:ExpirationMinutes", 15); |
Collaborator
There was a problem hiding this comment.
Эта операция происходит каждый раз при добавлении данных в кэш, а могла бы происходить один раз при создании службы
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ФИО: Морозов Сергей
Номер группы: 6513
Номер лабораторной: 1
Номер варианта: 47
Краткое описание предметной области: Транспортное средство
Краткое описание добавленных фич: Добавлен сервис генерации и кэширование через redis