Open
Conversation
github-actions
bot
added
In progress
danlla
requested changes
Mar 4, 2026
danlla
requested changes
Mar 4, 2026
Comment on lines
+62
to
+70
| lock (_lock) | ||
| { | ||
| if (_config.Services.Count == 0) | ||
| { | ||
| return Task.FromResult<Response<ServiceHostAndPort>>( | ||
| new ErrorResponse<ServiceHostAndPort>(new ServicesAreEmptyError("Weighted services list is empty"))); | ||
| } | ||
|
|
||
| _currentIndex = (_currentIndex + 1) % _config.TotalWeight; |
There was a problem hiding this comment.
lock лучше начать с обращения к _currentIndex, выше не должно быть проблем с потокобезопасностью
| if (_config.Services.Count == 0) | ||
| { | ||
| return Task.FromResult<Response<ServiceHostAndPort>>( | ||
| new ErrorResponse<ServiceHostAndPort>(new ServicesAreEmptyError("Weighted services list is empty"))); |
There was a problem hiding this comment.
Тут наверно все же пустой список из сервисов генераторов
Comment on lines
+88
to
+89
| return Task.FromResult<Response<ServiceHostAndPort>>( | ||
| new ErrorResponse<ServiceHostAndPort>(new ServicesAreEmptyError("Weighted services list is empty"))); |
There was a problem hiding this comment.
И тут тоже сообщение в ошибке стоит другое сделать
Тип тоже вряд ли подходит, но хотя бы сообщение поменять
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ФИО: Сукач Данил
Номер группы: 6511
Номер лабораторной: 2
Номер варианта: 15
Краткое описание предметной области: Кредитная заявка
Краткое описание добавленных фич: Добавлен балансировщик нагрузки