feature/524_add-version-to-help-text#525
Conversation
redcatbear
left a comment
redcatbear
left a comment
There was a problem hiding this comment.
I did a prereview of my own changes. I found a broken skill link in the process. Hence the skill changes that have nothing to do with this PR per-se.
| <resource> | ||
| <directory>src/main/resources</directory> | ||
| <filtering>false</filtering> | ||
| <excludes> | ||
| <exclude>version.properties</exclude> | ||
| </excludes> | ||
| </resource> |
There was a problem hiding this comment.
Why is the file included and excluded?
| <resource> | |
| <directory>src/main/resources</directory> | |
| <filtering>false</filtering> | |
| <excludes> | |
| <exclude>version.properties</exclude> | |
| </excludes> | |
| </resource> |
There was a problem hiding this comment.
Look at the filtering. Strange as this looks, that restores the default behavior which is overridden if you add an include or exclude. I was puzzled too. It looks weird, but is correct.
| #### CLI Version | ||
| `dsn~cli.version~1` | ||
|
|
||
| The CLI provides the current version of OpenFastTrace read from the resource file `version.properties`. |
There was a problem hiding this comment.
Reading from a resource file is an implementation detail. If you want to be so specific, please also describe how the version gets into this file ;)
There was a problem hiding this comment.
Good point. Added explanation where that file comes from and why we do it that way. SSoT.
|
2 participants
Close #524.