Feature/vite 8 beta - #7
Draft
tuj wants to merge 22 commits into
Draft
Conversation
Resolved three conflicts: - package.json: kept react-router/react-router-dom at ^7.12.0. The incoming side dropped the stale react-router ^5.2.0 dependency; this branch had already replaced it with the real v7 package, so that intent is preserved. - CHANGELOG.md: kept both sides, with the Unreleased entry above the incoming rc4-rc8 history. - package-lock.json: regenerated with npm rather than hand-merged. Refreshed the dependency tree while resolving the lockfile: npm audit goes from 12 advisories (8 high) to zero. All but one were fixed by in-range updates; esbuild needed ^0.27.2 -> ^0.28.2. Verified: vite build emits all three entries, vitest 57/57 pass.
fixTime built its pinned clock by mutating the current date. On the 31st of a month, setMonth(8) carried day-of-month 31 into September, which has 30 days, so the date overflowed to 1 October and setDate(15) then landed on 15 October instead of 15 September. calendar-0-single-booking asserted on "september" and failed. Constructing the date in a single call keeps it stable on every calendar date while still tracking the current year.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See:
os2display#341