fix thread unsafe call to localtime on linux#835
Open
aleksisch wants to merge 1 commit into
Open
Conversation
On Windows GetLocalTime is thread-safe. On linux localtime_r is thread-safe, while localtime not. This commit replaces usage of localtime in places not under mutex (only one such place) to localtime_r.
aleksisch
force-pushed
the
make-linux-thread-safe
branch
from
938c564 to
343437b
Compare
aleksisch
added a commit
to GaijinEntertainment/daScript
that referenced
this pull request
May 18, 2026
MCP requires HV. Let's enable HV by default so MCP server will be available in default builds. It requires fixing thread-safe bug in libHV: ithewei/libhv#835 And fixing our CMakeLists for ASAN on linux.
aleksisch
added a commit
to GaijinEntertainment/daScript
that referenced
this pull request
May 18, 2026
MCP requires HV. Let's enable HV by default so MCP server will be available in default builds. It requires fixing thread-safe bug in libHV: ithewei/libhv#835 And fixing our CMakeLists for ASAN on linux.
There was a problem hiding this comment.
Pull request overview
This PR fixes a thread-safety issue in the logging timestamp formatting on non-Windows platforms by avoiding localtime() (which uses shared static storage) in logger_print, replacing it with the thread-safe localtime_r().
Changes:
- Replace
localtime()withlocaltime_r()inlogger_printon non-Windows builds to avoid data races.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
379
to
383
| gettimeofday(&tv, NULL); | ||
| time_t tt = tv.tv_sec; | ||
| tm = localtime(&tt); | ||
| struct tm tm_buf; | ||
| tm = localtime_r(&tt, &tm_buf); | ||
| year = tm->tm_year + 1900; |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On Windows GetLocalTime is thread-safe. On linux localtime_r is thread-safe, while localtime not. This commit replaces usage of localtime in places not under mutex (only one such place) to localtime_r.
This bug was detected in daScript CI:
https://github.com/GaijinEntertainment/daScript/actions/runs/25911600620/job/76157878377?pr=2668