Support new corner reflector CSV format#176
Merged
bhawkins merged 13 commits intoisce-framework:developfrom Mar 9, 2026
Merged
Support new corner reflector CSV format#176bhawkins merged 13 commits intoisce-framework:developfrom
bhawkins merged 13 commits intoisce-framework:developfrom
Conversation
Tyler-g-hudson
approved these changes
Dec 16, 2025
Contributor
Tyler-g-hudson
left a comment
Tyler-g-hudson
left a comment
There was a problem hiding this comment.
Having read over all of this, it's hard to find fault with anything - LGTM!
|
|
||
|
|
||
| # There's a branch in the RCS vs angle model, so make sure the RCS is continuous | ||
|
|
Contributor
Author
|
Need to add test file description to README file |
rad-eng-59
approved these changes
Mar 5, 2026
Contributor
rad-eng-59
left a comment
rad-eng-59
left a comment
There was a problem hiding this comment.
LGTM. Thank you for the fix, update, and comprehensive test.
|
|
||
| import isce3 | ||
|
|
||
| class CRShape(str, Enum): |
Contributor
There was a problem hiding this comment.
FYI, if necessary, in order to make the enum case insensitive (str.casefold()) to the string inputs, one can update __missing__ classmethod in Enum as shown here
Tyler-g-hudson
pushed a commit
that referenced
this pull request
Mar 10, 2026
* wip support square trihedrals and new format * Move CR model into a separate function for easier testing * Remove "triangular" from names in isce3 * Remove "LSAR" from flags for easier refactor and support "Shape" column in CSV. * check peak RCS value in unit test * Add RCS continuity check * Add new format CSV unit test. Fix capitalization. * Generalize abscal workflow to square trihedrals * Generalize PTA to square trihedrals * Update some comments * Add a note about the new .csv test file.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
NASA and ISRO data processing teams agreed to some updates to the corner reflector CSV file specification. In particular, we added some validity codes to distinguish LSAR and SSAR usage, and we added a "Shape" column to distinguish triangular and square trihedrals. This PR implements support for these new features while retaining backwards compatibility.
When I went to implement the formula for a square trihedral (GO model), I was surprised that the one we have for triangular trihedrals didn't look quite right. All I can figure is that somebody misunderstood what was meant by "direction cosines" in the references. We ended up with the correct RCS for the region near the boresight, but the other branch in the formula was wrong. It's especially surprising because I could've sworn this came up earlier and Geoff had fixed it, but I guess not. Anyway, here are plots of the trihedral RCS vs angle before and after the fix in this PR (lines are contours at 3 dB intervals):
I added unit tests that check the boresight RCS against the simple formulas, and I added a unit test that verifies that a cut through the pattern is continuous. I also manually ran
nisarqaon an RSLC image that I'd run before and verified that I got the same abscal factor.