fix: use Map keyed by callID to prevent race condition in command restoration#11
Open
kszarek wants to merge 1 commit intoisanchez31:mainfrom
Open
fix: use Map keyed by callID to prevent race condition in command restoration#11kszarek wants to merge 1 commit intoisanchez31:mainfrom
kszarek wants to merge 1 commit intoisanchez31:mainfrom
Conversation
…toration - Replace lastOriginalCommand with originalCommands Map - Store commands by callID in tool.execute.before - Retrieve and delete by callID in tool.execute.after - Add test for concurrent command execution
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fix a race condition where concurrent bash tool invocations could overwrite each other's original command, causing the wrong command to be displayed in the UI after execution. The plugin stores the original command in
tool.execute.beforeto restore it intool.execute.afterfor UI display. Previously, a single shared variable was used, so if two bash commands ran concurrently, the second command'sbeforehook would overwrite the first command's original value before itsafterhook could restore it.Changes
let lastOriginalCommand: string | undefinedwithconst originalCommands = new Map<string, string>()in src/index.tsoriginalCommands.set(input.callID, command)originalCommands.get(input.callID)andoriginalCommands.delete(input.callID)Testing
bun test)Related Issues
Closes #