Skip to content

facet-tree spec: build URLs with explorerUrl() (fork sub-path safe) #353

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
rdhyee merged 1 commit into from
Aug 28, 2026
Merged

facet-tree spec: build URLs with explorerUrl() (fork sub-path safe) #353

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 11 additions & 10 deletions tests/playwright/facet-tree.spec.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,7 @@
* R2 publish; flip the skip / drop ?data_base once the files are remote.
*/
const { test, expect } = require('@playwright/test');
const { explorerUrl } = require('./helpers/url');

const LOCAL = !!process.env.FACET_TREE_LOCAL;
const DATA = LOCAL ? '&data_base=/data' : '';
Expand All @@ -31,7 +32,7 @@ test.describe('Material facet tree (#281/#282 preview)', () => {
test.describe.configure({ retries: 2 });

test('flag OFF → Material stays a flat list (no tree nodes)', async ({ page }) => {
await page.goto(`/explorer.html?facets=flat${DATA}${WORLD}`);
await page.goto(explorerUrl(`?facets=flat${DATA}${WORLD}`));
await page.waitForFunction(
() => document.querySelectorAll('#materialFilterBody .facet-row[data-facet="material"]').length > 0,
null, { timeout: 90000 });
Expand All @@ -40,7 +41,7 @@ test.describe('Material facet tree (#281/#282 preview)', () => {
});

test('flag ON → tree renders; selecting a parent filters the table to its subtree', async ({ page }) => {
await page.goto(`/explorer.html?facets=tree${DATA}${WORLD}`);
await page.goto(explorerUrl(`?facets=tree${DATA}${WORLD}`));
await page.waitForFunction(
() => document.querySelectorAll('#objectTypeFilterBody .facet-treenode').length > 0,
null, { timeout: 90000 });
Expand Down Expand Up @@ -91,7 +92,7 @@ test.describe('Material facet tree (#281/#282 preview)', () => {
const m = (document.getElementById('tablePageInfo')?.textContent || '').match(/of ([\d,]+)\)/);
return m ? parseInt(m[1].replace(/,/g, ''), 10) : null;
});
await page.goto(`/explorer.html?facets=tree${DATA}${WORLD}`);
await page.goto(explorerUrl(`?facets=tree${DATA}${WORLD}`));
await page.waitForFunction(
() => document.querySelectorAll('#objectTypeFilterBody .facet-treenode').length > 0,
null, { timeout: 90000 });
Expand Down Expand Up @@ -124,7 +125,7 @@ test.describe('Material facet tree (#281/#282 preview)', () => {
const EARTHMATERIAL = 'https://w3id.org/isample/vocabulary/material/1.0/earthmaterial';
// Select earthmaterial, then assert the URL carries ONLY that node (minimal — no
// expanded descendants like /mineral).
await page.goto(`/explorer.html?facets=tree${DATA}${WORLD}`);
await page.goto(explorerUrl(`?facets=tree${DATA}${WORLD}`));
await page.waitForFunction(() => document.querySelectorAll('#objectTypeFilterBody .facet-treenode').length > 0, null, { timeout: 90000 });
await page.evaluate(() => {
const cb = document.querySelector('#materialFilterBody input[value*="/earthmaterial"]');
Expand Down Expand Up @@ -163,7 +164,7 @@ test.describe('Material facet tree (#281/#282 preview)', () => {
test('live counts: tree node counts shrink to the viewport (not static baseline)', async ({ page }) => {
test.setTimeout(180000);
// Global view → baseline (global tree counts).
await page.goto(`/explorer.html?facets=tree${DATA}#v=1&lat=0&lng=0&alt=15000000`);
await page.goto(explorerUrl(`?facets=tree${DATA}#v=1&lat=0&lng=0&alt=15000000`));
await page.waitForFunction(() => document.querySelectorAll('#objectTypeFilterBody .facet-treenode').length > 0, null, { timeout: 90000 });
await page.waitForTimeout(2500);
const globalEarth = await legendCount(page, '/earthmaterial');
Expand All @@ -182,7 +183,7 @@ test.describe('Material facet tree (#281/#282 preview)', () => {

test('live counts coherence: legend(node) == table when that node is the filter (#245), parent >= child', async ({ page }) => {
test.setTimeout(180000);
await page.goto(`/explorer.html?facets=tree${DATA}#v=1&lat=35&lng=33&alt=500000`);
await page.goto(explorerUrl(`?facets=tree${DATA}#v=1&lat=35&lng=33&alt=500000`));
await page.waitForFunction(() => document.querySelectorAll('#objectTypeFilterBody .facet-treenode').length > 0, null, { timeout: 90000 });
// Select earthmaterial, then poll until the LEGEND count and the TABLE total
// converge to the same value. Both are viewport-scoped and settle to the zoomed
Expand Down Expand Up @@ -213,7 +214,7 @@ test.describe('Material facet tree (#281/#282 preview)', () => {
});
return s;
}, container);
await page.goto(`/explorer.html?facets=tree${DATA}#v=1&lat=35&lng=33&alt=500000`);
await page.goto(explorerUrl(`?facets=tree${DATA}#v=1&lat=35&lng=33&alt=500000`));
await page.waitForFunction(() => document.querySelectorAll('#objectTypeFilterBody .facet-treenode').length > 0, null, { timeout: 90000 });
await page.waitForTimeout(3500);
const matEarth0 = await legendCount(page, '/earthmaterial');
Expand Down Expand Up @@ -248,7 +249,7 @@ test.describe('Material facet tree (#281/#282 preview)', () => {

test('#291: Sampled Feature + Specimen Type also render as trees and filter', async ({ page }) => {
test.setTimeout(150000);
await page.goto(`/explorer.html?facets=tree${DATA}${WORLD}`);
await page.goto(explorerUrl(`?facets=tree${DATA}${WORLD}`));
await page.waitForFunction(
() => document.querySelectorAll('#objectTypeFilterBody .facet-treenode').length > 0, null, { timeout: 90000 });
const shape = await page.evaluate(() => ({
Expand Down Expand Up @@ -279,7 +280,7 @@ test.describe('Material facet tree (#281/#282 preview)', () => {

test('#291: simultaneous selections across all three tree dims register + round-trip to the URL', async ({ page }) => {
test.setTimeout(150000);
await page.goto(`/explorer.html?facets=tree${DATA}${WORLD}`);
await page.goto(explorerUrl(`?facets=tree${DATA}${WORLD}`));
await page.waitForFunction(
() => document.querySelectorAll('#objectTypeFilterBody .facet-treenode').length > 0, null, { timeout: 90000 });
// Check one node in each tree (material, context, object_type). Verify the
Expand Down Expand Up @@ -309,7 +310,7 @@ test.describe('Material facet tree (#281/#282 preview)', () => {
// materialTreeActive() is false everywhere → selection/filtering use the flat
// facets_v3 path (NOT the missing membership file).
await page.route('**/*facet_tree_summaries*', route => route.fulfill({ status: 404, body: '' }));
await page.goto(`/explorer.html?facets=tree${DATA}${WORLD}`);
await page.goto(explorerUrl(`?facets=tree${DATA}${WORLD}`));
await page.waitForFunction(
() => document.querySelectorAll('#materialFilterBody .facet-row[data-facet="material"]').length > 0,
null, { timeout: 90000 });
Expand Down
Loading