Kit Visualizer: Don't author omni:scenePartition attribute onto viewport camera when visualizing all envs #6223
Draft
rilei-nvidia wants to merge 1 commit into
Conversation
…ort camera if all environments are visible
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Previously, the value "env_0" was authored onto the Perspective Camera when using the kit visualizer. E.g.
./isaaclab.sh train --rl_library rsl_rl \ --task Isaac-Lift-KukaAllegro-Camera \ presets=newton_mjwarp,isaacsim_rtx_renderer,rgb64,single_camera \ --seed 42 \ --num_envs 4 \ --max_iterations 100 \ --visualizer kitThis caused only the first environment to be made visible, per scenePartition behavior:

In the case where we want to visualize all envs (
_resolved_visible_env_ids is None) - we should not be authoring theomni:scenePartitionattribute at all.The reason this is a draft PR is that there is a bug in IsaacSim RTX renderer where if a camera does not have the

omni:scenePartitionattribute, none of the partitioned prims are visible to the viewport (below I've removed the attribute):Checklist
pre-commitchecks with./isaaclab.sh --formatconfig/extension.tomlfileCONTRIBUTORS.mdor my name already exists there