Expose Same-Step terminal observations#6219
Open
ooctipus wants to merge 1 commit into
Open
Conversation
ooctipus
requested review from
Mayankm96,
jtigue-bdai and
kellyguo11
as code owners
ooctipus
force-pushed
the
support-vector-autoreset-modes
branch
5 times, most recently
from
60bc064 to
9df17c3
Compare
Contributor
|
Greptile encountered an error while reviewing this PR. Please reach out to support@greptile.com for assistance. |
ooctipus
force-pushed
the
support-vector-autoreset-modes
branch
3 times, most recently
from
1de310c to
a48f14d
Compare
ooctipus
changed the title
ooctipus
force-pushed
the
support-vector-autoreset-modes
branch
from
a48f14d to
9b0e1d0
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
metadata["autoreset_mode"] = gym.vector.AutoresetMode.SAME_STEPon RL envs.extras["final_obs"]for Direct RL, Manager-based RL, and Direct MARL envs.Sb3VecEnvWrapperto useextras["final_obs"]as SB3terminal_observationwhen envs reset on the same step.Validation
pre-commit run --files source/isaaclab/changelog.d/support-autoreset-modes.rst source/isaaclab/isaaclab/envs/direct_marl_env.py source/isaaclab/isaaclab/envs/direct_rl_env.py source/isaaclab/isaaclab/envs/manager_based_rl_env.py source/isaaclab_rl/changelog.d/support-autoreset-final-obs.rst source/isaaclab_rl/isaaclab_rl/sb3.py source/isaaclab_rl/test/test_sb3_wrapper_autoreset.pyPYTHONPATH=source/isaaclab:source/isaaclab_rl /home/zhengyuz/Projects/IsaacLab.wt/develop/.venv/bin/python -m pytest source/isaaclab_rl/test/test_sb3_wrapper_autoreset.pyPYTHONPATH=source/isaaclab:source/isaaclab_rl /home/zhengyuz/Projects/IsaacLab.wt/develop/.venv/bin/python -m py_compile source/isaaclab/isaaclab/envs/direct_marl_env.py source/isaaclab/isaaclab/envs/direct_rl_env.py source/isaaclab/isaaclab/envs/manager_based_rl_env.py source/isaaclab_rl/isaaclab_rl/sb3.py source/isaaclab_rl/test/test_sb3_wrapper_autoreset.pygit diff --check