Fix recipe book navigation - #993
Merged
isXander merged 2 commits intoSep 27, 2026
Merged
Conversation
isXander
approved these changes
Sep 27, 2026
Owner
|
I appreciate the regression test, and the AI disclosure! |
dx-Arcus
added a commit
to dx-Arcus/Controlify-Enhanced
that referenced
this pull request
Sep 28, 2026
One commit since the last sync: 07797f1, "Fix recipe book navigation (isXander#993)" by thatdutchguy, merged into isXander's main on 27 Sep. With a controller, the recipe book's page arrows and category tabs are clicked by RecipeBookScreenProcessor, which asked for mouse button 0. Minecraft 26.3 numbers the mouse buttons from 1 - its left button is 1, and a widget ignores any other - so on 26.3 those clicks did nothing. The fix asks for InputConstants.MOUSE_BUTTON_LEFT instead, which is 0 on 26.1 and 26.2 and 1 on 26.3. The rest is isXander's client game test for it: a test class, an accessor and two registrations, none of which the normal build compiles. This fork has never changed any of the five files, so nothing overlaps. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01SCgENUudgFMwSP3DqiLoEC
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Navigating recipe book tabs/pages stopped working with the 26.3 update.
Fixed by replacing the hardcoded value for the mouse button click by
InputContants.MOUSE_BUTTON_LEFT.Verified to build and work with 26.3, 26.2 and 26.1.
Tests written with help from ChatGPT Astra.