Repository navigation
fix: register iris, sodium and simple voice chat compat mixins - #1018
Open
offline-ant wants to merge 1 commit into
Open
offline-ant wants to merge 1 commit into
offline-ant wants to merge 1 commit into
Conversation
The manifest checked deps.* properties, but versions define dep.* (and dep.rso), so the compat mixin configs were never listed in fabric.mod.json or neoforge.mods.toml. The voice chat config was also named controlify-compat.svc.mixins.json instead of controlify-compat.simple-voice-chat.mixins.json. Without PTTKeyHandlerMixin, controller push-to-talk and whisper binds never reach Simple Voice Chat.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The common manifest in
build.gradle.ktsguards the compat mixin configs withifPresent("deps.…"), but the version properties are nameddep.…(and Reese's Sodium Options isdep.rso). Socontrolify-compat.iris,.sodium,.reeses-sodium-optionsand the voice chat config were never listed infabric.mod.json/neoforge.mods.toml. The voice chat entry also namedcontrolify-compat.svc.mixins.json, while the file iscontrolify-compat.simple-voice-chat.mixins.json.Without
PTTKeyHandlerMixin, the Simple Voice Chat binds (Push-To-Talk Hold/Toggle, Whisper) register but never reach SVC, so controller push-to-talk does nothing. This is what 3.5.3+mc26.3 currently ships.The compat configs keep their
CompatMixinPluginmod check, so listing them is safe when the mod is absent.Tested:
CI_SINGLE_BUILD=26.3 ./gradlew build: the Fabric and NeoForge manifests now list the iris, sodium and simple-voice-chat configs (26.3 defines nodep.rso).