feat(api): add backward-compatible LocalASNumber field to BGPPeer#421
Merged
Conversation
nikatza
force-pushed
the
fix-bgppeer-api-change
branch
2 times, most recently
from
9b7abe1 to
483b6f0
Compare
nikatza
force-pushed
the
fix-bgppeer-api-change
branch
from
483b6f0 to
535478d
Compare
nikatza
force-pushed
the
fix-bgppeer-api-change
branch
3 times, most recently
from
d1642f9 to
74323b0
Compare
nikatza
force-pushed
the
fix-bgppeer-api-change
branch
2 times, most recently
from
c5ac98e to
e566162
Compare
nikatza
force-pushed
the
fix-bgppeer-api-change
branch
2 times, most recently
from
9f000f3 to
6fb8018
Compare
Re-add the deprecated LocalASNumber field to BGPPeerSpec for backward compatibility with existing deployments. This field was removed in commit 05973e0 in favor of the new LocalAS struct. Migration strategy: - LocalASNumber is marked as deprecated in godoc - CEL validation prevents using both fields simultaneously - Webhook returns deprecation warning when LocalASNumber is used - Controller converts LocalASNumber to LocalAS with default prepend flags LocalASNumber will be removed in a future release once all deployments have migrated. Signed-off-by: Pujol <enric.pujol@sap.com>
nikatza
force-pushed
the
fix-bgppeer-api-change
branch
from
6fb8018 to
fe31398
Compare
Merging this branch changes the coverage (1 decrease, 1 increase)
Coverage by fileChanged files (no unit tests)
Please note that the "Total", "Covered", and "Missed" counts above refer to code statements instead of lines of code. The value in brackets refers to the test coverage of that file in the old version of the code. Changed unit test files
|
felix-kaestner
approved these changes
Jun 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Re-add the deprecated LocalASNumber field to BGPPeerSpec for backward compatibility with existing deployments. This field was removed in commit 05973e0 in favor of the new LocalAS struct.
Migration strategy:
LocalASNumber will be removed in a future release once all deployments have migrated.