[Draft] Merging the upstream/rolling EventsExecutor here#141
Open
jfinken wants to merge 2 commits intoirobot/humblefrom
Open
[Draft] Merging the upstream/rolling EventsExecutor here#141jfinken wants to merge 2 commits intoirobot/humblefrom
jfinken wants to merge 2 commits intoirobot/humblefrom
Conversation
added 2 commits
February 9, 2024 11:04
The commit also includes a few test fixes and temporary comments allowing the unit-tests, and the full package, to build.
Get the upstream executor_notify_waitable.cpp/.hpp and the test_executors_timer_cancel_behavior unit-test
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Getting this started. This PR pulls in the EventsExecutor code from the upstream
rclcpp,rollingbranch into here.Locally:
irobot_lock_free_events_queue(which remains where it is...)With respect to the ros2-performance framework, on an iRobot robot, I ran 60-sec
white_mountainmultiple times with each EventsExecutor:EventsExecutor from the dedicated iRobot repo, CPU-utilization, last line
"upstream" EventsExecutor, from the experimental namespace, CPU-utilization, last line