[pci] Ignore invalid subordinate bus numbers #1619
Merged
+14
−7
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some systems (observed on a Dell C6615) fail to correctly populate the subordinate PCI bus number on some PCI bridges. We do not currently guard against this behaviour, causing us to subsequently scan through a huge expanse of the PCI bus:dev.fn address range. Fix by ignoring the subordinate bus number if it is lower than the bridge's own bus number. Reported-by: Anisse Astier <an.astier@criteo.com> Reported-by: Ahmad Mahagna <ahmhad@nvidia.com> Signed-off-by: Michael Brown <mcb30@ipxe.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some systems (observed on a Dell C6615) fail to correctly populate the subordinate PCI bus number on some PCI bridges. We do not currently guard against this behaviour, causing us to subsequently scan through a huge expanse of the PCI bus:dev.fn address range.
Fix by ignoring the subordinate bus number if it is lower than the bridge's own bus number.
Fixes: #1618
Reported-by: Anisse Astier an.astier@criteo.com
Reported-by: Ahmad Mahagna ahmhad@nvidia.com