precompiles: Handle allocation failure in call_precompile#1582
Open
ywy2090 wants to merge 1 commit into
Open
Conversation
The result of the nothrow output buffer allocation was not checked. On allocation failure the precompile execution would write to a null pointer. Return EVMC_INTERNAL_ERROR instead.
chfast
requested changes
Jul 13, 2026
chfast
left a comment
chfast
left a comment
Member
There was a problem hiding this comment.
Not a good fix because this is not certain anyone will handle EVMC_INTERNAL_ERROR. We should redesign memory allocation for precompiles instead.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The result of the nothrow output buffer allocation in
call_precompile()was not checked (noted by the existingTODO: handle nullptr). On allocation failure the precompile execution would write to a null pointer. ReturnEVMC_INTERNAL_ERRORinstead.