Add attribute SafetyLevel to the component Stacks#179
Open
ipa-nhg wants to merge 17 commits intoipa320:2.0.0_stablefrom
Open
Add attribute SafetyLevel to the component Stacks#179ipa-nhg wants to merge 17 commits intoipa320:2.0.0_stablefrom
ipa-nhg wants to merge 17 commits intoipa320:2.0.0_stablefrom
Conversation
…erface Create GUI for configuring deployment
…ks, the package of the name was not corresponding to the one set for package.xml
Ros2 launch generator fix
Deployment support ros2
Add delpoyment documentation
fix ROS_HOSTNAME in docker-compose
ipa-nhg
force-pushed
the
2.0.0_stable
branch
from
1af1885 to
7352eb0
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@ipa-rwu FYI!
This PR adds to the ComponentStacks the attribute SafetyLevel, the changes proposed here allow to set the following 3 levels:
The Xtext grammar is updated, the new attribute is optional and the auto-complete function is working:
If needed, further cases can be easily added by modifying the list of accepted Strings on the Xext file, i.e., here: https://github.com/ipa-nhg/ros-model/blob/SafetyLevelSubSystems/plugins/de.fraunhofer.ipa.rossystem.xtext/src/de/fraunhofer/ipa/rossystem/RosSystem.xtext#L58
Once the modification is done, the Xtext backend must be re-generated. To make ti, right-click on the editor part and select Run As → Generate Xtext Artifacts:
Once completed (it should take ~30 seconds), you can just run the RosTooling.
Metamodel changes are not required, for ecore I described the attribute as a String (https://github.com/ipa-nhg/ros-model/blob/SafetyLevelSubSystems/plugins/de.fraunhofer.ipa.rossystem/model/rossystem.ecore#L28).