Repository navigation
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
thetaPC
added this pull request to stack #31629
October 21, 2026 23:00
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue number: resolves internal
What is the current behavior?
Button's tests skip the ionic theme in several specs, take a separate screenshot for every variant, and never check the default
shape,fillandsize. In md, activated screenshots don't show the ripple, which only appears on a real press.What is the new behavior?
No component code changes. This sets the baselines the button migration is compared against, so its snapshot diffs come only from the migration.
shapeper theme, and the defaultfillandsizeinside parents such asion-buttonsandion-item.ion-activatedelements, andgotowaits for it, so md activated screenshots show the pressed state. This also updates the activated snapshots of card, item, item-sliding, tab bar and toolbarTODO(FW-6838)). Its text fails contrast once the ripple is visible, and that predates this PRDoes this introduce a breaking change?
Other information
The migration PR is stacked on this one.