Repository navigation
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue number: internal
What is the current behavior?
Currently, patch releases are done by hand from the Confluence checklist. That means creating the release branch, running the release workflow, opening two PRs, turning on merge commits, merging with the exact commit format, turning merge commits back off and then setting up the Jira release. It's easy to miss a step, and forgetting to turn merge commits back off has happened before.
What is the new behavior?
This adds
scripts/release-patch.sh, which walks through the patch release one step at a time. It runs the mechanical steps throughghand stops for anything that needs a person, like confirming the changelog or posting the code freeze in Slack. It turns merge commits on for the merges and back off afterwards, even if the script errors out or gets interrupted. It also prints a single Jira search link that finds the tickets for every PR in the release.The Jira site and project key are read from
~/.config/ionic-release.envinstead of being kept in the repo (to prevent them from being committed by accident), andscripts/release.env.exampleis the template for that file. The script stops before doing anything if that file is missing, if a value is still a placeholder, or if the account running it isn't a repo admin.Does this introduce a breaking change?
Other information
ghCLI installed and authenticated to run this script.The values for the config file are on the Releases page on Confluence. Running
./scripts/release-patch.sh --dry-rungoes through the whole release without changing anything, so it's the easiest way to try it out. Use--step Nto resume a release that stopped partway through.