Repository navigation
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
brandyscarney
approved these changes
Oct 21, 2026
brandyscarney
left a comment
brandyscarney
left a comment
Member
There was a problem hiding this comment.
Looks good just some minor requests!
Co-authored-by: Brandy Smith <6577830+brandyscarney@users.noreply.github.com>
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue number: resolves internal
What is the current behavior?
Test pages pick their testing font from the
<html>classes. Onionic-modular,<html>has both the mode and theme classes, so anmdtheme page iniosmode gets the iOS testing font instead of themdone.What is the new behavior?
themeattribute Ionic sets on<html>for all three themes, instead of the mode and theme classes, so each theme gets its own font in either mode.configs()combination already pairs a theme with its own font, so no screenshots change.Does this introduce a breaking change?
Other information
Found in the title animations PR review (#31559). Tracked in FW-7883.
How to test
mdtheme,iosmodemdtheme inmdmode, instead of the iOS system font