Repository navigation
test(title): update snapshots for the title migration - #31615
Merged
Merged
Conversation
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue number: resolves internal
What is the current behavior?
#31539 changes how
ion-titlerenders, so snapshots across components no longer match. Its snapshot updates were moved here so its diff is only code.What is the new behavior?
Regenerates the snapshots with the Update Reference Screenshots workflow. They change for these reasons:
huetest: baselines forionic-md,mdandios.mdtheme instead of the header'smode="ios".title-basicin Chrome, where the long small title wraps one word sooner.mdpage that shows a title, on the title row only.Does this introduce a breaking change?
Other information
Merge this into #31539 before #31539 merges, so
ionic-modularnever has stale snapshots.