Skip to content

fix(datetime): fix overlap in datetime-button modal from datetime being too short #31274

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
droc101 wants to merge 1 commit into
base: main
Choose a base branch
from
+1 −1
Open

fix(datetime): fix overlap in datetime-button modal from datetime being too short #31274

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion core/src/css/core.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -405,7 +405,7 @@ ion-input input::-webkit-date-and-time-value {
*/
.ion-datetime-button-overlay ion-datetime.datetime-grid {
width: 320px;
min-height: 320px;
min-height: 350px;
}
Comment on lines +408 to 409

@thetaPC thetaPC Jul 21, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work tracking this down. Your diagnosis is correct: the overlap comes from .ion-datetime-button-overlay ion-datetime.datetime-grid overriding the datetime's height, and it undercuts the min-height: 350px that iOS declares for itself in datetime.ios.scss. It looks like a long standing bug rather than an intentional choice.

One refinement before we merge. The current rule applies to every mode, but the overlap is iOS only. In iOS mode the calendar rows are allowed to collapse, so a six-week month gets crammed into the capped height and the day highlights overlap. In MD mode each row cannot shrink below the day size, so the calendar just grows the overlay taller and never overlaps. That means bumping the shared rule to 350px also grows MD overlays that did not need it.

Suggested change
min-height: 350px;
}
min-height: 320px;
}
/**
* In iOS mode the calendar rows are allowed to collapse, so a month
* spanning six week-rows overlaps the selection highlights when the
* overlay caps the height at 320px. Restore the iOS grid min-height
* (refer to datetime.ios.scss) so six-week months have room.
*/
html.ios .ion-datetime-button-overlay ion-datetime.datetime-grid {
min-height: 350px;
}


/**
Expand Down
Loading