-
Notifications
You must be signed in to change notification settings - Fork 13.4k
feat(textarea): adjusting min-height of the textarea for ionic theme #30950
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: next
Are you sure you want to change the base?
Changes from all commits
4620d25
2ef9d30
fcc4bf4
4062300
228df5f
df337e8
0d7441e
f205099
631cea2
13f92b3
6398b20
44984f9
9ad8705
223ce69
d65d117
0be00d5
dd58785
791a201
bf9c315
239488f
10b94bc
7b8aa7a
493e575
b9bf225
89f53f3
876e094
99a8725
417c219
a814a80
49e8b35
eae4132
16c8adc
7b67b7c
c72c75c
3f62dc5
560c64f
4d569f0
f009c42
18bfbe8
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
|
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I think we can remove the shape, fill & label placement examples from this test. The only thing we really need to check for is things that will be affected by rows which is the default textareas,
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Agree. Accepting suggestion! |
| Original file line number | Diff line number | Diff line change | ||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| @@ -0,0 +1,144 @@ | ||||||||||||||
| <!DOCTYPE html> | ||||||||||||||
| <html lang="en" dir="ltr"> | ||||||||||||||
| <head> | ||||||||||||||
| <meta charset="UTF-8" /> | ||||||||||||||
| <title>Textarea - Rows</title> | ||||||||||||||
| <meta | ||||||||||||||
| name="viewport" | ||||||||||||||
| content="width=device-width, initial-scale=1.0, minimum-scale=1.0, maximum-scale=1.0, user-scalable=no" | ||||||||||||||
| /> | ||||||||||||||
| <link href="../../../../../css/ionic.bundle.css" rel="stylesheet" /> | ||||||||||||||
| <link href="../../../../../scripts/testing/styles.css" rel="stylesheet" /> | ||||||||||||||
| <script src="../../../../../scripts/testing/scripts.js"></script> | ||||||||||||||
| <script nomodule src="../../../../../dist/ionic/ionic.js"></script> | ||||||||||||||
| <script type="module" src="../../../../../dist/ionic/ionic.esm.js"></script> | ||||||||||||||
| <style> | ||||||||||||||
| .grid { | ||||||||||||||
| display: grid; | ||||||||||||||
| grid-template-columns: repeat(3, minmax(250px, 1fr)); | ||||||||||||||
|
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
Suggested change
|
||||||||||||||
| grid-row-gap: 20px; | ||||||||||||||
| grid-column-gap: 20px; | ||||||||||||||
| } | ||||||||||||||
|
|
||||||||||||||
| h2 { | ||||||||||||||
| font-size: 12px; | ||||||||||||||
| font-weight: normal; | ||||||||||||||
| color: #6f7378; | ||||||||||||||
| margin-top: 10px; | ||||||||||||||
| } | ||||||||||||||
|
|
||||||||||||||
| @media screen and (max-width: 800px) { | ||||||||||||||
| .grid { | ||||||||||||||
| grid-template-columns: 1fr; | ||||||||||||||
| padding: 0; | ||||||||||||||
| } | ||||||||||||||
| } | ||||||||||||||
|
Comment on lines
+30
to
+35
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
Suggested change
See above change that accounts for this |
||||||||||||||
| </style> | ||||||||||||||
| </head> | ||||||||||||||
|
|
||||||||||||||
| <body> | ||||||||||||||
| <ion-app> | ||||||||||||||
| <ion-header> | ||||||||||||||
| <ion-toolbar> | ||||||||||||||
| <ion-title>Textarea - Rows</ion-title> | ||||||||||||||
| </ion-toolbar> | ||||||||||||||
| </ion-header> | ||||||||||||||
|
|
||||||||||||||
| <ion-content id="content" class="ion-padding"> | ||||||||||||||
| <div class="grid"> | ||||||||||||||
| <div class="grid-item"> | ||||||||||||||
| <h2>Rows: 3</h2> | ||||||||||||||
| <ion-textarea | ||||||||||||||
| rows="3" | ||||||||||||||
| label="Comments" | ||||||||||||||
| label-placement="stacked" | ||||||||||||||
| helper-text="rows=3, label-placement=stacked" | ||||||||||||||
| value="1 2 3 4 5 6 7 8 9 0" | ||||||||||||||
| ></ion-textarea> | ||||||||||||||
| </div> | ||||||||||||||
|
|
||||||||||||||
| <div class="grid-item"> | ||||||||||||||
| <h2>Rows: 2</h2> | ||||||||||||||
| <ion-textarea | ||||||||||||||
| rows="2" | ||||||||||||||
| label="Small" | ||||||||||||||
| label-placement="stacked" | ||||||||||||||
| helper-text="rows=2, label-placement=stacked" | ||||||||||||||
| value="1 2 3 4 5 6 7 8 9 0" | ||||||||||||||
| ></ion-textarea> | ||||||||||||||
| </div> | ||||||||||||||
|
|
||||||||||||||
| <div class="grid-item"> | ||||||||||||||
| <h2>Rows: 5</h2> | ||||||||||||||
| <ion-textarea | ||||||||||||||
| rows="5" | ||||||||||||||
| label="Medium" | ||||||||||||||
| label-placement="stacked" | ||||||||||||||
| helper-text="rows=5, label-placement=stacked" | ||||||||||||||
| value="1 2 3 4 5 6 7 8 9 0" | ||||||||||||||
| ></ion-textarea> | ||||||||||||||
| </div> | ||||||||||||||
|
|
||||||||||||||
| <div class="grid-item"> | ||||||||||||||
| <h2>Rows: 8</h2> | ||||||||||||||
| <ion-textarea | ||||||||||||||
| rows="8" | ||||||||||||||
| label="Large" | ||||||||||||||
| label-placement="stacked" | ||||||||||||||
| helper-text="rows=8, label-placement=stacked" | ||||||||||||||
| value="1 2 3 4 5 6 7 8 9 0" | ||||||||||||||
| ></ion-textarea> | ||||||||||||||
| </div> | ||||||||||||||
|
|
||||||||||||||
| <div class="grid-item"> | ||||||||||||||
| <h2>Rows: 3, Size Small</h2> | ||||||||||||||
| <ion-textarea | ||||||||||||||
| rows="3" | ||||||||||||||
| size="small" | ||||||||||||||
| label="Small Size" | ||||||||||||||
| label-placement="stacked" | ||||||||||||||
| helper-text="rows=3, size=small, label-placement=stacked" | ||||||||||||||
| value="1 2 3 4 5 6 7 8 9 0" | ||||||||||||||
| ></ion-textarea> | ||||||||||||||
| </div> | ||||||||||||||
|
|
||||||||||||||
| <div class="grid-item"> | ||||||||||||||
| <h2>Rows: 3, Size Medium</h2> | ||||||||||||||
| <ion-textarea | ||||||||||||||
| rows="3" | ||||||||||||||
| size="medium" | ||||||||||||||
| label="Medium Size" | ||||||||||||||
| label-placement="stacked" | ||||||||||||||
| helper-text="rows=3, size=medium, label-placement=stacked" | ||||||||||||||
| value="1 2 3 4 5 6 7 8 9 0" | ||||||||||||||
| ></ion-textarea> | ||||||||||||||
| </div> | ||||||||||||||
|
|
||||||||||||||
| <div class="grid-item"> | ||||||||||||||
| <h2>Rows: 3, Size Large</h2> | ||||||||||||||
| <ion-textarea | ||||||||||||||
| rows="3" | ||||||||||||||
| size="large" | ||||||||||||||
| label="Large Size" | ||||||||||||||
| label-placement="stacked" | ||||||||||||||
| helper-text="rows=3, size=large, label-placement=stacked" | ||||||||||||||
| value="1 2 3 4 5 6 7 8 9 0" | ||||||||||||||
| ></ion-textarea> | ||||||||||||||
| </div> | ||||||||||||||
|
|
||||||||||||||
| <div class="grid-item"> | ||||||||||||||
| <h2>Rows: 3, Auto-grow</h2> | ||||||||||||||
| <ion-textarea | ||||||||||||||
| rows="3" | ||||||||||||||
| auto-grow="true" | ||||||||||||||
| label="Comments" | ||||||||||||||
| label-placement="stacked" | ||||||||||||||
| helper-text="rows=3, auto-grow=true, label-placement=stacked" | ||||||||||||||
| value="1 2 3 4 5 6 7 8 9 0" | ||||||||||||||
| ></ion-textarea> | ||||||||||||||
| </div> | ||||||||||||||
| </div> | ||||||||||||||
| </ion-content> | ||||||||||||||
| </ion-app> | ||||||||||||||
| </body> | ||||||||||||||
| </html> | ||||||||||||||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is the icon placement after the changes right? It looks really close to the top:
nextFrom Figma:
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Well spotted! That's indeed a bug!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed