Repository navigation
docs(desktop): clarify that desktop usage is not officially supported - #4814
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
brandyscarney
left a comment
brandyscarney
left a comment
There was a problem hiding this comment.
Looks good, just a few nits, not blocking!
|
|
||
| ::: | ||
|
|
||
| Ionic supports the following browsers: |
There was a problem hiding this comment.
Right after saying desktop isn't supported, we say this and list Edge and Firefox. Can we qualify the table? Something like 'Ionic supports the following browser versions on the mobile platforms listed above', or explain that these are the minimum browser engine versions. Otherwise a reader can still take the table as desktop support.
There was a problem hiding this comment.
Agreed. The Chrome and Safari minimums match the Mobile Platforms table exactly in v9 and v8, so I think this is really a list of minimum engine versions. Are the Edge and Firefox rows still meant to be here? They don't map to anything in that table, so they're what makes it read as desktop support.
There was a problem hiding this comment.
Done in 6743567. I went with your first wording and linked "mobile platforms" to that section, in the note too.
There was a problem hiding this comment.
Commenting here for thread
Cross Platform still says Ionic apps can run as an Electron app, which reads as desktop support. Should it get the same ‘can run, not officially supported’ wording (or a link to Browser Support) so the docs give one answer? See below link
There was a problem hiding this comment.
+1, and the v8 copy has it too. We missed this line when #3366 removed the desktop section from that page, so I think it fits in this PR, but a follow-up is fine if you'd rather keep this one small.
There was a problem hiding this comment.
Good catch, done in a613cdb. It now says Electron and desktop browsers can run Ionic apps but desktop usage is not officially supported, with a link to the mobile platforms list.
| ## Native Access {/* #native-access */} | ||
|
|
||
| An amazing feature of apps built with web technologies (such as Ionic apps!) is that it can run on virtually any platform: desktop computers, phones, tablets, cars, refrigerators, and more! The same code base for Ionic apps can work on many platforms because it is based on web standards and common APIs that are shared across these platforms. | ||
| An amazing feature of apps built with web technologies (such as Ionic apps!) is that it can run on virtually any platform: desktop computers, phones, tablets, cars, refrigerators, and more! The same code base for Ionic apps can work on many platforms because it is based on web standards and common APIs that are shared across these platforms. That said, Ionic Framework is designed and tested for mobile platforms. Refer to [Browser Support](../reference/browser-support.mdx) for the platforms it officially supports. |
There was a problem hiding this comment.
Should we link to ../reference/browser-support.mdx#mobile-platforms so it goes to the officially supported mobile platforms list? Or is this supposed to link to #browsers? It's a bit confusing since we list desktop browsers at the end.
There was a problem hiding this comment.
| An amazing feature of apps built with web technologies (such as Ionic apps!) is that it can run on virtually any platform: desktop computers, phones, tablets, cars, refrigerators, and more! The same code base for Ionic apps can work on many platforms because it is based on web standards and common APIs that are shared across these platforms. That said, Ionic Framework is designed and tested for mobile platforms. Refer to [Browser Support](../reference/browser-support.mdx) for the platforms it officially supports. | |
| An amazing feature of apps built with web technologies (such as Ionic apps!) is that it can run on virtually any platform: desktop computers, phones, tablets, cars, refrigerators, and more! The same code base for Ionic apps can work on many platforms because it is based on web standards and common APIs that are shared across these platforms. That said, Ionic Framework is designed and tested for mobile platforms. Refer to [Browser Support](../reference/browser-support.mdx#mobile-platforms) for the platforms it officially supports. |
I'd go with #mobile-platforms since that's the section listing what's officially supported. The v8 copy can take the same change.
There was a problem hiding this comment.
It's meant to point at the officially supported list, so I changed it to #mobile-platforms in 8433d60.
ShaneK
left a comment
ShaneK
left a comment
There was a problem hiding this comment.
Looks good to me! I just added a few notes on top of Brandy's.
|
|
||
| ::: | ||
|
|
||
| Ionic supports the following browsers: |
There was a problem hiding this comment.
Agreed. The Chrome and Safari minimums match the Mobile Platforms table exactly in v9 and v8, so I think this is really a list of minimum engine versions. Are the Edge and Firefox rows still meant to be here? They don't map to anything in that table, so they're what makes it read as desktop support.
There was a problem hiding this comment.
+1, and the v8 copy has it too. We missed this line when #3366 removed the desktop section from that page, so I think it fits in this PR, but a follow-up is fine if you'd rather keep this one small.
| ## Native Access {/* #native-access */} | ||
|
|
||
| An amazing feature of apps built with web technologies (such as Ionic apps!) is that it can run on virtually any platform: desktop computers, phones, tablets, cars, refrigerators, and more! The same code base for Ionic apps can work on many platforms because it is based on web standards and common APIs that are shared across these platforms. | ||
| An amazing feature of apps built with web technologies (such as Ionic apps!) is that it can run on virtually any platform: desktop computers, phones, tablets, cars, refrigerators, and more! The same code base for Ionic apps can work on many platforms because it is based on web standards and common APIs that are shared across these platforms. That said, Ionic Framework is designed and tested for mobile platforms. Refer to [Browser Support](../reference/browser-support.mdx) for the platforms it officially supports. |
There was a problem hiding this comment.
| An amazing feature of apps built with web technologies (such as Ionic apps!) is that it can run on virtually any platform: desktop computers, phones, tablets, cars, refrigerators, and more! The same code base for Ionic apps can work on many platforms because it is based on web standards and common APIs that are shared across these platforms. That said, Ionic Framework is designed and tested for mobile platforms. Refer to [Browser Support](../reference/browser-support.mdx) for the platforms it officially supports. | |
| An amazing feature of apps built with web technologies (such as Ionic apps!) is that it can run on virtually any platform: desktop computers, phones, tablets, cars, refrigerators, and more! The same code base for Ionic apps can work on many platforms because it is based on web standards and common APIs that are shared across these platforms. That said, Ionic Framework is designed and tested for mobile platforms. Refer to [Browser Support](../reference/browser-support.mdx#mobile-platforms) for the platforms it officially supports. |
I'd go with #mobile-platforms since that's the section listing what's officially supported. The v8 copy can take the same change.
Issue URL: ionic-team/ionic-framework#30570
What is the current behavior?
The docs say different things about desktop usage. Fundamentals says Ionic apps run on "desktop computers", and Browser Support lists desktop browsers with no qualifier, so both read as official desktop support. The popover page also describes dropdown menus as a "desktop-focused" use case.
What is the new behavior?
Applied to the current docs and v8.
Does this introduce a breaking change?
Other information
#30570 asked whether desktop is supported, and the docs gave conflicting answers.