Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
resolves #1945
What is the current behavior?
The
URL Parameterssection indocs/vue/navigation.mdreads route params by callinguseRoute()in<script setup>and destructuringroute.params.id. That couples the component to the router instance, which Vue Router's own docs discourage and which makes the component harder to reuse or test in isolation.What is the new behavior?
The example now uses
props: trueon the route record anddefineProps<{ id: string }>()in the component, mirroring Vue Router's recommended pattern. The intro recommends the props approach up front, and the closing line calls out that the component has no router dependency.The same change is also backported to the v7 docs.