Skip to content

part 2#2266

Open
arteck wants to merge 5 commits into
ioBroker:masterfrom
arteck:master
Open

part 2#2266
arteck wants to merge 5 commits into
ioBroker:masterfrom
arteck:master

Conversation

@arteck
Copy link
Copy Markdown
Contributor

@arteck arteck commented Jun 3, 2026

Performance optimizations part 2
fix filter in tab scripts

Copilot AI review requested due to automatic review settings June 3, 2026 15:34
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Note

Copilot was unable to run its full agentic suite in this review.

This PR focuses on performance and UX improvements, primarily by optimizing subscription dispatch for state changes and improving script list filtering/counting in the editor UI, along with a patch version bump and regenerated admin/editor build artifacts.

Changes:

  • Introduces O(1) subscription dispatch indexing (exact-id map + wildcard list) to reduce per-state-change overhead.
  • Improves editor script list filtering and folder child counts under active filters.
  • Updates versions/build artifacts and minor refactors (handler IDs, structuredClone, regex precompilation, intervals unref()).

Reviewed changes

Copilot reviewed 17 out of 30 changed files in this pull request and generated 7 comments.

Show a summary per file
File Description
src/types.d.ts Extends JavascriptContext typing to include the new subscription dispatch indexes.
build/types.d.ts Built typings updated to match new JavascriptContext fields.
src/main.ts Adds subscription dispatch indexes and uses them during state change dispatch; minor loop/interval tweaks.
src/lib/sandbox.ts Maintains the dispatch index when subscribing/unsubscribing; adds caching and cloning changes.
src-editor/src/SideMenu.tsx Adds recursive visibility checks and filtered descendant counting for folders.
src-editor/package.json Bumps editor package patch version.
src-admin/package.json Bumps admin package patch version.
src-admin/.mf/diagnostics/latest.json Updates module-federation diagnostics content (currently machine-specific).
package.json Updates release-script devDependencies.
admin/tab.html Updates built asset references.
admin/mf-manifest.json Updates built manifest asset references/hashes.
admin/assets/stateHoverProvider-C1-TGN9W.js Regenerated admin bundle artifact.
admin/assets/localSharedImportMap-W-vnZT9_.js Regenerated admin bundle artifact.
admin/assets/index-C54xn1sZ.js Regenerated admin bundle artifact.
admin/assets/index-B-2d1Nd2.js Regenerated admin bundle artifact.
admin/assets/ScriptEditorVanillaMonaco-ujcpmhdX.js Regenerated admin bundle artifact.
admin/assets/ScriptEditor-BxbSX-vo.js Regenerated admin bundle artifact.
admin/assets/AiChatPanel-BMNd_R3U.js Regenerated admin bundle artifact.
README.md Adds WIP changelog notes for the upcoming changes.
Files not reviewed (5)
  • admin/remoteEntry.js: Language not supported
  • build/lib/sandbox.js: Language not supported
  • build/main.js: Language not supported
  • src-admin/package-lock.json: Language not supported
  • src-editor/package-lock.json: Language not supported

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread src/lib/sandbox.ts
Comment thread src/main.ts
Comment thread src-editor/src/SideMenu.tsx
Comment thread src/lib/sandbox.ts Outdated
Comment thread src/lib/sandbox.ts
Comment thread src-admin/.mf/diagnostics/latest.json Outdated
Comment thread src/lib/sandbox.ts Outdated
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants