part 2#2266
Open
arteck wants to merge 5 commits into
Open
Conversation
There was a problem hiding this comment.
Pull request overview
Note
Copilot was unable to run its full agentic suite in this review.
This PR focuses on performance and UX improvements, primarily by optimizing subscription dispatch for state changes and improving script list filtering/counting in the editor UI, along with a patch version bump and regenerated admin/editor build artifacts.
Changes:
- Introduces O(1) subscription dispatch indexing (exact-id map + wildcard list) to reduce per-state-change overhead.
- Improves editor script list filtering and folder child counts under active filters.
- Updates versions/build artifacts and minor refactors (handler IDs,
structuredClone, regex precompilation, intervalsunref()).
Reviewed changes
Copilot reviewed 17 out of 30 changed files in this pull request and generated 7 comments.
Show a summary per file
| File | Description |
|---|---|
| src/types.d.ts | Extends JavascriptContext typing to include the new subscription dispatch indexes. |
| build/types.d.ts | Built typings updated to match new JavascriptContext fields. |
| src/main.ts | Adds subscription dispatch indexes and uses them during state change dispatch; minor loop/interval tweaks. |
| src/lib/sandbox.ts | Maintains the dispatch index when subscribing/unsubscribing; adds caching and cloning changes. |
| src-editor/src/SideMenu.tsx | Adds recursive visibility checks and filtered descendant counting for folders. |
| src-editor/package.json | Bumps editor package patch version. |
| src-admin/package.json | Bumps admin package patch version. |
| src-admin/.mf/diagnostics/latest.json | Updates module-federation diagnostics content (currently machine-specific). |
| package.json | Updates release-script devDependencies. |
| admin/tab.html | Updates built asset references. |
| admin/mf-manifest.json | Updates built manifest asset references/hashes. |
| admin/assets/stateHoverProvider-C1-TGN9W.js | Regenerated admin bundle artifact. |
| admin/assets/localSharedImportMap-W-vnZT9_.js | Regenerated admin bundle artifact. |
| admin/assets/index-C54xn1sZ.js | Regenerated admin bundle artifact. |
| admin/assets/index-B-2d1Nd2.js | Regenerated admin bundle artifact. |
| admin/assets/ScriptEditorVanillaMonaco-ujcpmhdX.js | Regenerated admin bundle artifact. |
| admin/assets/ScriptEditor-BxbSX-vo.js | Regenerated admin bundle artifact. |
| admin/assets/AiChatPanel-BMNd_R3U.js | Regenerated admin bundle artifact. |
| README.md | Adds WIP changelog notes for the upcoming changes. |
Files not reviewed (5)
- admin/remoteEntry.js: Language not supported
- build/lib/sandbox.js: Language not supported
- build/main.js: Language not supported
- src-admin/package-lock.json: Language not supported
- src-editor/package-lock.json: Language not supported
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Performance optimizations part 2
fix filter in tab scripts