Open
Conversation
…alize undefined fields in assertions
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Feature + fix: enhanced the built-in
collectnode to support chaining viacollect.collectionwhile preserving existing multi-collect.itembehavior.Why:
Collect -> Collectworkflows (similar to @skunkworxdark'scollection_tools) without breaking existing graphs.How:
invokeai/app/services/shared/graph.py):collectupdated toversion="1.1.0".collectionas a real connection input.item, single-input behavior forcollection.T | list[T] | None).collect.collectionin schema parsing.collectionchains.graph_bench.py(list(map(...))change).Related Issues / Discussions
https://discord.com/channels/1020123559063990373/1130288930319761428/1477387080966471802
QA Instructions
Backend:
pytest -q tests/test_node_graph.py -k "collector or iterate_accepts_collection or iterate_validates_collection_inputs_against_iterator_outputs"Frontend:
cd invokeai/frontend/web && pnpm run lint:tsccd invokeai/frontend/web && node_modules/.bin/vitest run src/features/nodes/store/util/getCollectItemType.test.ts src/features/nodes/store/util/validateConnection.test.tsMerge Plan
Checklist
What's Newcopy (if doing a release after this PR)