[uss_qualifier/astm] Make cleanup phase in down_uss use estimated extents as well#1405
Open
the-glu wants to merge 1 commit intointeruss:mainfrom
Open
[uss_qualifier/astm] Make cleanup phase in down_uss use estimated extents as well#1405the-glu wants to merge 1 commit intointeruss:mainfrom
the-glu wants to merge 1 commit intointeruss:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR should fix #1400 by also using estimated extends during cleanup phase.
Initial cleanup was not doing anything during initial phase since it was using
scenario_execution_max_extentsonly, where as check was done onestimated_max_extents.I didn't verify exact scenario in original issue, but looking at report, there is now a query to perform clean up:
(before, no query was done:
so potentially existing OP intents would not being deleted
)
And having a previous test leaving an OPI cleanup it as expected:
The other usage of
estimate_scenario_execution_max_extentsdon't perform any cleanup (but does perform an 'area clear' check), so I didn't change anything there.