Repository navigation
Conversation
Switching to Spanish left most of ia-reviews in English. Ten msg() calls failed extraction outright (template literals with an expression and no str tag, and msg() on a stored string), "Delete this review" and "(edited)" were never wrapped, and none of the three elements re-rendered on a locale switch. - Add @Localized() to ia-reviews, ia-review and ia-review-form. - Use str for the review count, star titles, rating labels, character limits and the edited date. Split "Display review(s)" and "Rate N star(s)" into whole messages per form. - Resolve the recaptcha and generic errors, the delete outcome and the "Anonymous" fallback when they render, not when the element is built or the event fires. submitterScreenname is optional now. - The review date stays en-us. @lit/localize only exposes getLocale from configureLocalization, which the app owns. ia-reviews-localization.test.ts switches the locale live against a test-only catalog. Reverting each fix fails its own test. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01N6GtWdx3xKytP8c8CLtpAX
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01N6GtWdx3xKytP8c8CLtpAX
jbuckner
added this pull request to stack #123
October 1, 2026 19:08
|
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## WEBDEV-8840-review-service #133 +/- ##
==============================================================
+ Coverage 90.42% 90.70% +0.27%
==============================================================
Files 107 107
Lines 3886 3904 +18
Branches 964 970 +6
==============================================================
+ Hits 3514 3541 +27
+ Misses 153 150 -3
+ Partials 219 213 -6 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
…iews Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01RgyoVnVd6Wt6HHbGy3Vuvh
…iews Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01RgyoVnVd6Wt6HHbGy3Vuvh * origin/WEBDEV-8840-review-service: WEBDEV-9107: Answer the delete request locally in the reviews demo
* origin/WEBDEV-8840-review-service: 1.1.6 (#145) WEBDEV-9329: Update the Firefox add-on link in ia-topnav (#143) WEBDEV-9241: Add ia-wayback-search-form for the home page Wayback block (#134) WEBDEV-9219: Localize the topnav strings (#125) WEBDEV-9051: Migrate the donation form models, currency validator and form section into elements (#98) WEBDEV-9038: Migrate the topnav into elements (#95)
* origin/WEBDEV-8840-review-service: WEBDEV-9052: Migrate edit-donation into elements (#100)
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Wraps the rest of the ia-reviews strings in msg() and makes them follow a live locale switch.
WEBDEV-9240: https://webarchive.jira.com/browse/WEBDEV-9240
🤖 Generated with Claude Code
https://claude.ai/code/session_01N6GtWdx3xKytP8c8CLtpAX