WEBDEV-9053: Migrate the donation form payment layer into elements

[jbuckner]

WEBDEV-9053. Stacked on #100. Fourth of the five in WEBDEV-8602.

The payment layer of donation-form: the Braintree manager, payment clients, the five provider handlers (credit card, PayPal, Venmo, Apple Pay, Google Pay), the recaptcha manager and the Venmo session restoration handler. It lands under src/elements/ia-donation-form/braintree/. No custom elements in this one, so no story, it's the logic and its tests. The flow handlers go with the modals in the last rung since they render them.

What changed beyond the move:

• Real @types instead of the vendored 2020 copies. @types/braintree-web 3.143 splits the library module (typeof braintree.client, the thing with create()) from the instance (braintree.Client), where the old copy conflated them. PaymentClientsInterface and the handlers are typed that way now, and everything imports the types (import type * as braintree from 'braintree-web') rather than leaning on the UMD global. A globals.d.ts types window.braintree and window.paypal, which the CDN scripts create. The @types packages are regular dependencies because the published d.ts files reference them.
• fee_amount_covered is calculated from the fields. submitDonation already recomputed the total because donationInfo can arrive as a plain object (Venmo in Chrome) with none of the class getters. The fee custom field read the feeAmountCovered getter and would have been undefined in that case. Both are calculated the same way now, with a test using a plain object.
• The hosted fields retry is tidier. No async promise executor, and the timeout is cleared in a finally so a lost race can't leave a rejection with nowhere to go. Same behavior: our own timer races Braintree's create, a timer win retries, up to the max.
• The recaptcha onload callback is namespaced (iaDonationFormGrecaptchaLoaded). The old package uses donationFormGrecaptchaLoadedCallback, and a page loading both during the switch-over would have had them overwrite each other's callback and hang one form's recaptcha.
• HostedFieldContainer doesn't import BadgedInput. It only ever set .error on the parent, so it types the parent as an element with an error flag. The badged input element itself arrives with the form elements.
• Enums are as const objects plus a type, as in the earlier rungs.
• Two upstream changes are in. The Venmo restoration handler no longer throws in Safari private browsing when the storage global itself is blocked (iaux-donation-form#188). CreditCardHandler has a focusField the form uses to focus the card number (from iaux-donation-form#190). @types/braintree-web already has HostedFields.focus, so the vendored type patch isn't needed.

Tests moved from web-test-runner and sinon to Vitest, 88 of them. The mocks for the payment libraries live in braintree/test-helpers/*.test-helpers.ts, which the package's !dist/**/*.test* filter keeps out of the published tarball. The Apple Pay session mock now defines STATUS_SUCCESS and STATUS_FAILURE, which the old one didn't, so those assertions compared undefined to undefined and passed regardless.

Verified locally: build, full suite 1117 passing, eslint and prettier clean, no circular dependencies.

🤖 Generated with Claude Code

https://claude.ai/code/session_01QnX6VHo3EJRzcKfhzBChCf

[github-actions]

PR Preview Action v1.8.1
Preview removed because the pull request was closed.
2026-10-12 20:25 UTC

[codecov-commenter]

Codecov Report

❌ Patch coverage is 92.68707% with 43 lines in your changes missing coverage. Please review.
✅ Project coverage is 90.96%. Comparing base (57a21ba) to head (64597da).
⚠️ Report is 1 commits behind head on main.

Files with missing lines	Patch %	Lines
...aintree/test-helpers/mock-managers.test-helpers.ts	81.17%	16 Missing ⚠️
...raintree/test-helpers/mock-clients.test-helpers.ts	91.00%	9 Missing ⚠️
...ts/ia-donation-form/braintree/braintree-manager.ts	90.24%	2 Missing and 2 partials ⚠️
...providers/venmo/venmo-restoration-state-handler.ts	88.00%	2 Missing and 1 partial ⚠️
src/elements/ia-donation-form/recaptcha-manager.ts	89.65%	0 Missing and 3 partials ⚠️
...ts/ia-donation-form/braintree/payment-providers.ts	93.54%	2 Missing ⚠️
...ntree/payment-providers/credit-card/credit-card.ts	95.00%	1 Missing and 1 partial ⚠️
...-form/braintree/payment-providers/paypal/paypal.ts	85.71%	1 Missing and 1 partial ⚠️
...roviders/apple-pay/apple-pay-session-datasource.ts	96.96%	0 Missing and 1 partial ⚠️
...on-form/braintree/payment-providers/venmo/venmo.ts	94.11%	0 Missing and 1 partial ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main     #103      +/-   ##
==========================================
+ Coverage   90.67%   90.96%   +0.28%     
==========================================
  Files          96      118      +22     
  Lines        3519     4107     +588     
  Branches      843      904      +61     
==========================================
+ Hits         3191     3736     +545     
- Misses        137      170      +33     
- Partials      191      201      +10     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

[latonv]

LGTM, solid migration! Just flagged one oddity in the dependencies.