Make from and into required on merge_contacts_request (all versions)#582
Merged
Conversation
The merge endpoint (POST /contacts/merge) resolves from/into via find_user and cannot succeed without both, so they are de-facto required. Declare them in the schema across all supported API versions to match runtime behavior. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
dan0505
approved these changes
Jul 9, 2026
marcmlc
added a commit
that referenced
this pull request
Jul 9, 2026
PR #582/#1024 added a required: [from, into] block to every version, but the 2.11 spec already declared from/into required via a trailing required: list. The duplicate mapping key broke strict YAML parsing of the 2.11 spec. Remove the added block; the pre-existing declaration already makes both fields required. Co-authored-by: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why?
The merge endpoint (
POST /contacts/merge) cannot complete without bothfromandinto— a request omitting either is rejected server-side because neither contact can be resolved. The schema previously documented both as optional, so generated SDKs and the "Try it" console treated them as skippable, letting callers construct requests the API will always reject.How?
Add
required: [from, into]to themerge_contacts_requestschema across every versioned spec that defines the merge endpoint (2.7–2.15 and the unstable description). This is a spec-accuracy change only: it can only reject requests the backend would already reject.Generated with Claude Code