Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This branch fixes the SYCL triple-buffer/shadow-copy ownership bug by deferring misaligned host-pointer shadow-copy decisions until allocation time (via a new prepareForAllocation hook), so backend-aware policy can choose whether SYCL creates the shadow copy (NativeCPU/OpenCL/offload) or UR owns staging and final copy-back (Level Zero/CUDA/HIP).
It also adds a new end-to-end regression test (buffer_shadow_copy_platform_policy.cpp) that validates backend-dependent allocation behavior for misaligned read-only buffers and verifies correct data copy-back for writable buffers, covering the original failure mode and guarding against regressions.