Drop 32-bit support#232
Open
eparshut wants to merge 12 commits into
Open
Conversation
bump fortran gh action version add setup MSVC environment
There was a problem hiding this comment.
Pull request overview
This PR removes 32-bit build/runtime support across the ITT API repo, simplifying build scripts, build system options, bindings, and documentation to be 64-bit-only.
Changes:
- Removed 32-bit build controls (CMake
FORCE_32,-m32,buildall.py --force_bits) and deleted 32-bit ptmark assembly sources. - Simplified runtime environment variable handling to 64-bit-only (
INTEL_LIBITTNOTIFY64,INTEL_JIT_PROFILER64) across C/C#/Fortran APIs and docs. - Updated CI workflows and documentation to reflect the new build directory layout and requirements.
Reviewed changes
Copilot reviewed 23 out of 23 changed files in this pull request and generated 5 comments.
Show a summary per file
| File | Description |
|---|---|
| src/ittnotify/jitprofiling.c | Drops INTEL_JIT_PROFILER32 selection; uses 64-bit env var only. |
| src/ittnotify/ittptmark32.S | Removes 32-bit PT mark implementation (deleted file). |
| src/ittnotify/ittptmark32.asm | Removes 32-bit PT mark implementation for MASM (deleted file). |
| src/ittnotify/ittnotify_static.c | Removes 32-bit/ARM32 env-var/path branching; defaults to 64-bit env var/path. |
| src/ittnotify/ittnotify_config.h | Removes IA32 arch define/detection and related branches; bumps API version. |
| src/ittnotify_refcol/README.md | Updates ref collector usage to only reference INTEL_LIBITTNOTIFY64. |
| README.md | Updates build requirements/usage docs (CMake min version, removes --force_bits). |
| python/setup.py | Removes 32-bit selection logic for ptmark and assembler; hardcodes 64-bit ptmark tooling. |
| include/legacy/ittnotify.h | Removes non-Windows x86 cdecl/stdcall attribute branches. |
| include/jitprofiling.h | Removes non-Windows x86 cdecl attribute branch. |
| include/ittnotify.h | Removes non-Windows x86 cdecl/stdcall attribute branches. |
| include/fortran/advisor_annotate.f90 | Removes 32-bit env var branch; uses INTEL_LIBITTNOTIFY64 only. |
| include/AdvisorAnnotate.cs | Removes INTEL_LIBITTNOTIFY32 path selection; uses 64-bit env var only. |
| include/advisor-annotate.h | Removes x86-only calling convention branch and 32-bit env var selection. |
| docs/src/using-jit-api.rst | Updates build output path format to remove <target_bits> segment. |
| docs/src/ref_collector.rst | Updates ref collector docs to only reference INTEL_LIBITTNOTIFY64. |
| docs/src/jit-api-support.rst | Removes 32-bit env var documentation; describes 64-bit env var only. |
| docs/src/compile-and-link-with-itt-api.rst | Updates build output paths and removes 32-bit env var instructions. |
| docs/src/build.rst | Updates buildall usage/options to remove --force_bits and reflect current flags. |
| CMakeLists.txt | Removes 32-bit force option/flags and always selects 64-bit ptmark sources for IPT support. |
| buildall.py | Removes 32-bit build loop/flag; modernizes shell execution and build folder layout. |
| .github/workflows/release.yml | Updates CI steps for 64-bit-only builds; adds MSVC dev cmd; bumps setup-fortran. |
| .github/workflows/main.yml | Updates CI for new build folder layout; removes forced 64-bit flag; adds MSVC dev cmd. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
…D fallback to avoid breaking downstream 32-bit builds
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Remove 32-bit build support and related dead code across the repository: