Revert "pm: allow reset when reset type is set" - #83
Merged
Conversation
kwd-doodling
requested review from
lifenggitacc and
likongintel
as code owners
August 28, 2026 03:11
There was a problem hiding this comment.
Pull request overview
This PR reverts commit c46750677fb595924532ff7464fe4d9e7d31af4e, restoring the prior reset-preparation handling in the ISH always-on (AON) power-management task by removing the “reset type” special-case path.
Changes:
- Remove the
PMU_RST_AP_REBOOTconstant and associated logic that treated a specific reset type as sufficient to enter reset-prep handling. - Simplify reset-prep polling in
handle_d0i2()andhandle_d0i3()to only trigger whenPMU_RST_PREP_AVAILis set. - Remove the
PMU_RST_PREP_RESET_TYPEbitmask definition from the AON PMU register header.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| bsp_sedi/soc/intel_ish/pm/aon/ish_aontask.c | Reverts reset-prep polling behavior to only check PMU_RST_PREP_AVAIL, removing the reset-type override path. |
| bsp_sedi/soc/intel_ish/pm/aon/include/ish_registers.h | Removes the PMU_RST_PREP_RESET_TYPE mask definition that is no longer used after the revert. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This reverts commit c467506.
kwd-doodling
force-pushed
the
dwang4_revert_reset_type
branch
from
August 28, 2026 03:15
f685fc7 to
4731d83
Compare
likongintel
approved these changes
Aug 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This reverts commit c467506.