Skip to content

feat: add ID in data_source_github_repository_teams#3492

Open
acouvreur wants to merge 2 commits into
integrations:mainfrom
acouvreur:add-team-id-datasource
Open

feat: add ID in data_source_github_repository_teams#3492
acouvreur wants to merge 2 commits into
integrations:mainfrom
acouvreur:add-team-id-datasource

Conversation

@acouvreur

Copy link
Copy Markdown
Contributor

Before the change?

You cannot retrieve the ID from the github_repository_teams datasource, which is a pain when using associated resources that require a team ID.

After the change?

  • You can retrieve the ID from the github_repository_teams datasource, which is useful when using associated resources that require a team ID.

Pull request checklist

  • Schema migrations have been created if needed (example)
  • Tests for the changes have been added (for bug fixes / features) Cannot test because ID is generated from created repository, unless ID is retrieved in the tests before assertion
  • Docs have been reviewed and added / updated if needed (for bug fixes / features)

Does this introduce a breaking change?

Please see our docs on breaking changes to help!

  • Yes
  • No

The team ID was missing from the datasource.
@github-actions

Copy link
Copy Markdown

👋 Hi, and thank you for this contribution!

This repo is maintained by GitHub and community members on a best-effort basis. We'll get to this as soon as we can.

You can help us prioritize by joining the discussion on open issues and PRs, sharing details on the changes you need, and reviewing other contributions.


🤖 This is an automated message.

@stevehipwell

stevehipwell commented Jun 24, 2026

Copy link
Copy Markdown
Collaborator

@acouvreur please could you open an issue before creating a PR to save everyone's time.

FYI the data source already has id, as is enforced by the Terraform Plugin SDk v2, which is a string type; the code you've provided here would likely error. If we want to add an integer team ID we'd need to call it team_id, but please can we have that discussion in an issue.

Sorry, wrong data source. I take back my objection but the main point that opening an issue to be triaged before a PR still stands.

@acouvreur

Copy link
Copy Markdown
Contributor Author

@acouvreur please could you open an issue before creating a PR to save everyone's time.

FYI the data source already has id, as is enforced by the Terraform Plugin SDk v2, which is a string type; the code you've provided here would likely error. If we want to add an integer team ID we'd need to call it team_id, but please can we have that discussion in an issue.

Sorry, wrong data source. I take back my objection but the main point that opening an issue to be triaged before a PR still stands.

Will do, the change was so minimal I thought it'd be okay. Duly noted for next contributions

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants