fix(ui-source-code-editor): apply current theme to v2 search panel#2620
Open
ToMESSKa wants to merge 1 commit into
Open
Conversation
|
Visual regression report✅ No changes.
Baselines come from the |
matyasf
requested changes
Jul 2, 2026
matyasf
left a comment
matyasf
left a comment
Collaborator
There was a problem hiding this comment.
SearchPanelshows in the docs app, this is an internal component that should not show- see my inline comments also
| createPortal( | ||
| <SearchPanel | ||
| view={view} | ||
| searchConfig={this.props.searchConfig!} |
Collaborator
There was a problem hiding this comment.
This might be undefined if the prop's value changes runtime. Can you add something that only renders this if searchConfig is not null?
| } | ||
|
|
||
| private shouldUpdateExtensions(prevProps: SourceCodeEditorProps) { | ||
| const propsToObserve: (keyof SourceCodeEditorProps)[] = [ |
ToMESSKa
force-pushed
the
INSTUI-5081-source-code-editors-search-panel-is-not-applying-the-current-theme-v-2
branch
from
343e038 to
1710600
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
INSTUI-5081
ISSUE:
TEST PLAN:
cmd/ctrl+fescshould close the search panel