Redesign the preview pane for files with no built-in viewer…#208
Merged
Conversation
…er button (#1969) * feat(open-knowledge): redesign asset fallback pane + rename text-viewer button Rename the "Open with built-in text editor" button to "View as text" and restyle the no-viewer asset fallback pane (primary View-as-text action, mono extension chip, lighter filename). Regenerate Lingui en/pseudo catalogs. Also includes a dark:bg-transparent tweak to CreatePromptComposer. * chore(open-knowledge): add changeset for asset fallback redesign * docs(open-knowledge): finish stale text-viewer label comment sweep Replace remaining "Open with built-in text editor" comment references missed by the initial sweep (line-wrapped occurrences + tests/ and core/ files outside the original src/ grep scope). Comments only; no assertions or runtime behavior changed. Addresses PR #1969 review (claude). * style(open-knowledge): drop dead rounded-full on ext chip, add text-balance to filename Address PR #1969 review (claude, Consider-level): the extension chip's rounded-full had no visual effect without bg/border/padding — remove the dead class. Add text-balance to the filename heading to match the established text-2xl font-light heading pattern. --------- GitOrigin-RevId: 8f840134bad139eb923f6e35d59eaeb3d1d54349
![inkeep-internal-ci[bot]](https://avatars.githubusercontent.com/u/123133689?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Automated approval from agents-private public-mirror-sync (run: https://github.com/inkeep/agents-private/actions/runs/27788272363). Source of truth is the monorepo; direct edits on inkeep/open-knowledge are overwritten on next sync.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Redesign the preview pane for files with no built-in viewer (
.gitignore,.zip, dotfiles, and the long tail of formats). The "Open with built-in text editor" button is now "View as text" and leads as the primary action, with a refreshed extension chip and filename treatment.