(AgentChat) - realtime tool calls fix , (OpenAI) browser login gpt 4.1 option removed - #386
Open
lucifer78907 wants to merge 2 commits into
Open
(AgentChat) - realtime tool calls fix , (OpenAI) browser login gpt 4.1 option removed#386lucifer78907 wants to merge 2 commits into
lucifer78907 wants to merge 2 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Type of Change
Description
Two independent fixes:
1.
fix(chat)— tool execution progress never rendered in the web UI(
forge-ui/static/app.js)The
progressSSE handler looked for tool info in adatapart ofstatus.message.parts, but the agent doesn't send it that way: the tool nameand phase arrive in task metadata (
progress_tool/progress_phase) andthe human-readable line arrives as a text part. The
part.kind === 'data'branch therefore never matched and no tool card was ever appended.
The handler now:
progress_tool/progress_phasefromparsed.metadatatool_start/tool_endonto the barestart/endvaluesToolCardexpectsmessagemetadata tool name (tools execute sequentially, so start/end never interleave)
2.
fix(providers)— drop GPT 4.1 from the OpenAI model list(
forge-core/catalog/providers.go)Comments out the
GPT 4.1/gpt-4.1entry so it no longer appears in theprovider model picker. Left commented rather than deleted for easy restore.