chore: exclude rocksdb#147
Merged
Merged
Conversation
Member
this naming concerns me for some reason. what does the feature do? |
prestwich
approved these changes
May 21, 2026
Contributor
Author
Ultimately it enables the That means if we build artifacts on one machine and run them on another with a less-capable CPU, the binary could die at runtime when c-kzg or blst hits an unsupported instruction. I looked into turning it back on, but seems like it's already enabled via a different dep route: |
Member
|
okay gotcha. so ideally, this is turned off when we're making production builds? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
rocksdbdependency from our build by disabling default features on the workspacerethdep and re-listing the upstream defaults exceptrocksdb.rocksdbwas pulled in viareth→reth-provider(gated behindreth-provider/rocksdb, whichreth'sdefaultfeature enables). We don't use the rocksdb-backed provider paths, so this is dead weight - a heavy C++/bindgen build for no runtime benefit.Changes
Cargo.toml: workspacerethdep now usesdefault-features = falsewith an explicit feature list (jemalloc,otlp,otlp-logs,js-tracer,keccak-cache-global,asm-keccak,min-debug-logs) - i.e. upstream'sdefaultarray minusrocksdb.Note:
reth-revm/portableis in upstream'sdefaultarray but is a sub-crate feature directive that can't be re-listed by a consumer. If anything relied on portable revm it would need to be re-enabled via a separate path; nothing in this workspace appears to.