Repository navigation
chore: update asynchronous_batching.py to use exception in on_error f… - #735
Merged
Merged
Conversation
karel-rehor
force-pushed
the
examples/update_async_batching
branch
from
November 6, 2026 16:06
7c513f1 to
4581f15
Compare
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #735 +/- ##
==========================================
+ Coverage 90.43% 90.54% +0.10%
==========================================
Files 41 41
Lines 3577 3585 +8
==========================================
+ Hits 3235 3246 +11
+ Misses 342 339 -3 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
bednar
approved these changes
Nov 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed Changes
Replace the function passed to
on_errorinbatches.subscribewithdone.set_exceptionso that the exception will be propagated to the controlling Future.Currently
on_erroris simply a call to aprintfunction, so when an exception occurs the Futuredonenever properly ends. When this fails in thecheck-examplesjob in the CI pipeline it causes the job to hang until the job's timeout is reached (e.g. 10 min).With this change, if the example fails during the
check-examplescheck, it will fail faster and the underlying cause will be revealed.Checklist
[ ] CHANGELOG.md updatedN.A.[ ] A test has been added if appropriateadditional tests not neededpytest testscompletes successfully