Repository navigation
Conversation
The serializer tested 'key in timestamp_column', a substring check, so a field column whose name is part of the timestamp column name (Open with OpenTime) was treated as the timestamp and silently dropped. When every field matched that way the serializer raised IndexError. Closes influxdata#592
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #734 +/- ##
==========================================
+ Coverage 90.43% 90.54% +0.10%
==========================================
Files 41 41
Lines 3577 3585 +8
==========================================
+ Hits 3235 3246 +11
+ Misses 342 339 -3 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
…tamp-column-match # Conflicts: # CHANGELOG.md
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Requested by Taltal · project thread
Closes #592
Proposed Changes
DataframeSerializerdecided whether a column is the timestamp column withkey in timestamp_column, a substring check on the column name. Any field whose name is part of the timestamp column name was treated as the timestamp and dropped: withdata_frame_timestamp_column="OpenTime", theOpencolumn from #592 never reaches InfluxDB. If every field matches that way, serialization raisesIndexError.This compares the names with
==and adds a regression test withOpenTime,OpenandTimecolumns. The test fails onmasterwithIndexErrorand passes with the change.Checklist
pytest testscompletes successfully (offline suites: same results with and without this change; the tests that need a running InfluxDB were not run against a server)