Repository navigation
test: add test tls/mtls - #721
Conversation
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #721 +/- ##
==========================================
+ Coverage 90.55% 90.72% +0.16%
==========================================
Files 41 41
Lines 3589 3589
==========================================
+ Hits 3250 3256 +6
+ Misses 339 333 -6 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
93710f1 to
29b6f0a
Compare
fce50cd to
d41d2f9
Compare
There was a problem hiding this comment.
🟡 Changes recommended
The regeneration script targets a developer-specific absolute path instead of the current checkout.
1 open issue
What changed in this PR
Expands InfluxDB client tests for TLS and mutual TLS authentication.
Changes:
- Adds successful and rejected certificate scenarios and SSL context precedence coverage.
- Adds certificate fixtures and a regeneration script.
- Improves test server cleanup and refreshes the shared server certificate.
| File | Description |
|---|---|
| tests/test_InfluxDBClient.py | Adds TLS/mTLS cases and server cleanup. |
| tests/test_data/certificates/other-server.pem | Untrusted certificate/key bundle. |
| tests/test_data/certificates/other-server.key | Untrusted identity's test key. |
| tests/test_data/certificates/other-server.crt | Untrusted certificate fixture. |
| tests/test_data/certificates/influxdb.pem | Server certificate/key bundle. |
| tests/test_data/certificates/influxdb.key | Server test key. |
| tests/test_data/certificates/influxdb.crt | Trusted server certificate. |
| tests/test_data/certificates/client.pem | Client certificate/key bundle. |
| tests/test_data/certificates/client.key | Client test key. |
| tests/test_data/certificates/client.crt | Trusted client certificate. |
| tests/server.pem | Refreshes shared server fixture. |
| scripts/generate-self-signed-cert.sh | Generates certificate fixtures. |
Review effort: Balanced
9394b20 to
266438c
Compare
2dd4b17 to
a6f196b
Compare
88eb0d8 to
f9d11c0
Compare
karel-rehor
left a comment
There was a problem hiding this comment.
Looks good. But...
An update to examples/README.md would be helpful.
The basic mTLS example has a minor style problem.
f9d11c0 to
085d3e6
Compare
|
@karel-rehor |
One-line mention of examples/config_tls_mtls.py in examples/README.md added. |
karel-rehor
left a comment
There was a problem hiding this comment.
Tests pass locally with 3.12
Looks good to me. 🚴 🏁
c789b10 to
f9fe923
Compare
126befb to
91c198b
Compare


Closes #
Proposed Changes
Checklist
pytest testscompletes successfully