fix(reactotron-app): Exclude default._ artifacts from release uploads - #1620
Open
itz-puneet wants to merge 1 commit into
Open
fix(reactotron-app): Exclude default._ artifacts from release uploads#1620itz-puneet wants to merge 1 commit into
default._ artifacts from release uploads#1620itz-puneet wants to merge 1 commit into
Conversation
electron-builder emits `default._` prefixed duplicates of the macOS dmg
artifacts into the release folder. The upload filter in
`release.artifacts.js` drops directories, `.yml`, `.yaml` and `.blockmap`
files, but not these, so they are published alongside the real assets.
The most recent `reactotron-app@3.11.0` release shows both:
default._Reactotron-3.11.0-arm64.dmg
default._Reactotron-3.11.0.dmg
Reactotron-3.11.0-arm64.dmg
Reactotron-3.11.0.dmg
Adds a `default._` prefix filter. Checked against the full 3.11.0 asset
list: it removes exactly those two duplicates and leaves the other ten
assets (zip, dmg, AppImage, rpm, deb, snap, msi, exe) untouched.
There was a problem hiding this comment.
🟢 Approval recommended
The change is narrowly scoped to the intended artifact filtering behavior and matches the stated requirement without affecting other release assets.
Pull request overview
This PR updates the Reactotron app release artifact upload script to prevent electron-builder’s macOS default._ duplicate DMG artifacts from being included in GitHub release uploads, addressing issue #1329.
Changes:
- Add a filename prefix filter to exclude
default._*artifacts from the release upload list. - Document the rationale inline alongside existing artifact filters.
File summaries
| File | Description |
|---|---|
| apps/reactotron-app/scripts/release.artifacts.js | Adds a startsWith("default._") filter to prevent uploading electron-builder duplicate DMG artifacts. |
Review details
- Files reviewed: 1/1 changed files
- Comments generated: 0
- Review effort level: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #1329
Please verify the following:
yarn build-and-test:localpasses — not run locally, see note belowREADME.md(or relevant documentation) has been updated with your changes — n/a, no documented behaviour changesDescribe your PR
electron-builder emits
default._prefixed duplicates of the macOS dmg artifacts into the release folder. The upload filter inapps/reactotron-app/scripts/release.artifacts.jsdrops directories,.yml,.yamland.blockmapfiles, but nothing catches these, so they get published alongside the real assets.This is still happening on the most recent app release,
reactotron-app@3.11.0:The fix adds one filter for the
default._prefix, in the same style as the filters above it.Verification
I checked the filter against the complete 3.11.0 release asset list rather than only the two files named in the issue. It removes exactly the two duplicates and leaves all ten legitimate assets untouched:
default._Reactotron-3.11.0-arm64.dmgdefault._Reactotron-3.11.0.dmgReactotron-3.11.0-arm64-mac.zipReactotron-3.11.0-arm64.dmgReactotron-3.11.0-mac.zipReactotron-3.11.0.AppImageReactotron-3.11.0.dmgreactotron-app-3.11.0.x86_64.rpmreactotron-app_3.11.0_amd64.debreactotron-app_3.11.0_amd64.snapReactotron.3.11.0.msiReactotron.Setup.3.11.0.exeI chose
startsWith("default._")over a broader pattern deliberately — this is a release script, and a looser filter risks dropping real assets.Note on local verification
I was not able to run
yarn build-and-test:localin my environment, so I have left that box unchecked rather than tick it untruthfully. The change is a three-line addition to a Node script; I verified it parses withnode --checkand validated the filter logic against the real asset names above. Since this script only runs during a release, CI on this PR will not exercise it either — worth a maintainer eye on the next release run.